Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add code for computing service coverage windows and trip counts #1351

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

bdferris-v2
Copy link
Collaborator

Adds TripCalendarUtil, which provides methods for computing service coverage windows based on daily trip counts.
Will hopefully be useful for #886 and PR #1289.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues

Copy link
Collaborator

@briandonahue briandonahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @bdferris-v2 Thank you for this - I will incorporate this into my PR. @isabelle-dr What is the appropriate way of merging - merge into master and then merge master into PR #1289, or merge this into #1289 and close this one?

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1419 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1419 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1419 sources (~0 %) are corrupted.
Commit: c1ead9a
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@briandonahue
Copy link
Collaborator

@davidgamez @isabelle-dr Could someone take a look and merge this so that I can use it in #1289?

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bdferris-v2
❌ davidgamez
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1420 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1420 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1420 sources (~0 %) are corrupted.
Commit: 47ea948
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez merged commit 417387d into master Mar 15, 2023
@davidgamez davidgamez deleted the issue/886/date_validity branch March 15, 2023 18:29
ryon pushed a commit to JarvusInnovations/gtfs-validator that referenced this pull request Apr 1, 2023
…MobilityData#1351)

Add TripCalendarUtil, which provides methods for computing trip counts and service windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants