Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore web packages on acceptance and e2e tests #1403

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

davidgamez
Copy link
Member

@davidgamez davidgamez commented Apr 28, 2023

Summary:

The acceptance and E2E tests are time and cost-consuming workflows. As web projects have no impact on the validator's core implementation, we can ignore them in the mentioned test workflows. Web projects run their own independent set of tests.

Expected behavior:

When changes are pushed from web projects, the acceptance and E2E tests should not run.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez davidgamez marked this pull request as ready for review April 28, 2023 14:41
@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1426 sources (~0 %) are corrupted.
Commit: 0047f7a
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez requested review from KClough, bdferris-v2 and briandonahue and removed request for themightychris April 28, 2023 14:52
@davidgamez davidgamez merged commit 63bf659 into master Apr 28, 2023
@davidgamez davidgamez deleted the chore/ignore-web-e2e-acceptance-tests branch April 28, 2023 15:00
@bdferris-v2
Copy link
Collaborator

Won't this change have the same issue as #1339? Namely, acceptance test are required for merging a PR, so if we exclude the workflow, you'll need a repo admin to actually merge the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants