-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: 1640 add remaining gtfs features to the validator #1656
Feat: 1640 add remaining gtfs features to the validator #1656
Conversation
…lidator # Resolved Conflicts: # main/src/main/java/org/mobilitydata/gtfsvalidator/runner/ValidationRunner.java
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/FeedMetadata.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qcdyx Nice work! Two comments:
- I don't see
Pathways (extra)
when I test with MBTA's feed - I now get a
agency.txt. INVALID_HEADERS
error when I run the validator through the cli. This is making the agency column in the Summary report empty even when the agency is provided by the feed (which I can also see in your screenshot). I don't see this in our staging environment, so I'm wondering if this is introducing a new bug.
@qcdyx A requirement change: Transfer Rules should be renamed "Transfer Fares" |
❌ Invalid acceptance test. |
❌ Invalid acceptance test. |
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/FeedMetadata.java
Show resolved
Hide resolved
I expected no changes in the acceptance tests as #1640 tasks only relate to adding component information to the HTML and JSON formatting. Is it related to gtfs-validator/main/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsNetworkSchema.java Line 7 in 0657814
|
main/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsNetworkSchema.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/runner/ValidationRunner.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/runner/ValidationRunner.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsNetworkSchema.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsNetworkSchema.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/FareAttributeAgencyIdValidator.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/mobilitydata/gtfsvalidator/validator/MatchingFeedAndAgencyLangValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/RouteAgencyIdValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/UrlConsistencyValidator.java
Outdated
Show resolved
Hide resolved
@qcdyx Additional changes to scope (could make a new issue/PR for this one): Remove the following base components:
|
@emma just fixed the agency problem |
@qcdyx Rename Pathways to Pathways (basic) |
changed loadPathwayExtraComponent logic
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
…where we can test it in isolation.
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/FeedMetadata.java
Outdated
Show resolved
Hide resolved
@davidgamez I've made the changes and commented GtfsNetworkSchema code. I'll uncommented the code and remove the requested components in a new PR once this is merged. |
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/FeedMetadata.java
Outdated
Show resolved
Hide resolved
Thanks @qcdyx , Can you kindly remove the commented code from the PR? |
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qcdyx @davidgamez The example feeds all run correctly - only thing I notice is that Route Names hasn't been deleted. I'll let @jcpitre do the final review + merge :) |
@emmambd I have the route name deletion code locally. I'll commit it in a new PR together with GtfsNetworkSchema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary:
Added new GTFS features as described in #1640
Expected behavior:
![image](https://private-user-images.githubusercontent.com/5789435/298638936-719d87b1-330f-43b5-8439-76aa461cbdc6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU4OTIwNzgsIm5iZiI6MTcyNTg5MTc3OCwicGF0aCI6Ii81Nzg5NDM1LzI5ODYzODkzNi03MTlkODdiMS0zMzBmLTQzYjUtODQzOS03NmFhNDYxY2JkYzYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDlUMTQyMjU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjkwZTAwMjM3MjMwYTI0NDBkOWQ5ZDZmNDJiYjAwNzhkOGNlNTdmYmIzM2M0ODEzYjA5NDc1NWQyZDZiMjE5ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.KljjNJzojkCGAHvGEfHS6yhJfzMIY1QVTHhmOxben-k)
![image](https://private-user-images.githubusercontent.com/5789435/298639012-dd81a1f3-98c2-49d1-9aa6-4074216525b0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU4OTIwNzgsIm5iZiI6MTcyNTg5MTc3OCwicGF0aCI6Ii81Nzg5NDM1LzI5ODYzOTAxMi1kZDgxYTFmMy05OGMyLTQ5ZDEtOWFhNi00MDc0MjE2NTI1YjAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDlUMTQyMjU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NThmYjQ5Y2E3MTNkY2IyZTUyYmMxY2FkMWNlYWQ0ZjhmMDg1ZTExMTRlOTAyMDNkMDI4MDg2NzdlNGMzNjM5NiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.EuZcKe-veDgc1G8eUUqyiSeF2Trw0h5m0UVrcb30Opk)
MBTA.zip
Bullrunner.zip
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything