-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1776 add flex features to list #1780
base: master
Are you sure you want to change the base?
Conversation
…record in location_groups.txt
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit bcde487 📊 Notices ComparisonNew Errors (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1524 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
I think we have to wait to review/merge this until some other schemas are added and tested, e.g #1750 |
stop_id being required changes as part of #1749 |
I agree, even if we merge flex features won't be visible until the conditional requirement is added to the schema. |
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/FeedMetadata.java
Outdated
Show resolved
Hide resolved
…/FeedMetadata.java Co-authored-by: cka-y <[email protected]>
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 15a7c4f 📊 Notices ComparisonNew Errors (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1524 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
@@ -56,6 +56,9 @@ public interface GtfsStopTimeSchema extends GtfsEntity { | |||
@ForeignKey(table = "stops.txt", field = "stop_id") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary:
Closes #1776
Expected behavior:
I discovered that the primary reason most of the
stop_times.txt
files in flex feeds are unparsable is the absence of the requiredstop_id
field. So to test flex features, I commented @required annotation in the GtfsStopTimesSchema and generated the following report. We need to discuss the logic behind the requirement of thestop_id
field for non-flex feeds vs. flex feeds.(I cannot find a flex feed that meets Deviated Fixed Route criteria)
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything