feat: Validate that combination of route names and type are unique wi… #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thin an agency This logic corresponds to real-world use cases validated at Google for all its production feeds. Previous validation produced too many false positives because it ignored route type and validated uniqueness of short and long names separately.
lionel-nj
approved these changes
Mar 30, 2021
lionel-nj
previously requested changes
Mar 30, 2021
lionel-nj
suggested changes
Mar 30, 2021
There was a problem hiding this comment.
LGTM! Just one thing: README.md should be updated to reflect the changes.
Thanks @aababilov
|
Done! |
|
Thanks @aababilov ! :) |
|
Thanks for review, @lionel-nj ! |
lionel-nj
suggested changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…thin an agency
This logic corresponds to real-world use cases validated at Google for
all its production feeds.
Previous validation produced too many false positives because it ignored
route type and validated uniqueness of short and long names separately.