-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Validate that combination of route names and type are unique wi… #839
feat: Validate that combination of route names and type are unique wi… #839
Conversation
…thin an agency This logic corresponds to real-world use cases validated at Google for all its production feeds. Previous validation produced too many false positives because it ignored route type and validated uniqueness of short and long names separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aababilov LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that README.md
should be updated to reflect the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one thing: README.md
should be updated to reflect the changes.
Thanks @aababilov
Done! |
Thanks @aababilov ! :) |
Thanks for review, @lionel-nj ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one typo and then we're good to go :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏾 ✅ 🚀
…thin an agency
This logic corresponds to real-world use cases validated at Google for
all its production feeds.
Previous validation produced too many false positives because it ignored
route type and validated uniqueness of short and long names separately.