-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add NoticeSchemaGenerator #951
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
lionel-nj
reviewed
Aug 11, 2021
core/src/main/java/org/mobilitydata/gtfsvalidator/notice/NoticeSchemaGenerator.java
Show resolved
Hide resolved
lionel-nj
reviewed
Aug 11, 2021
core/src/main/java/org/mobilitydata/gtfsvalidator/notice/NoticeSchemaGenerator.java
Show resolved
Hide resolved
lionel-nj
reviewed
Aug 11, 2021
core/src/test/java/org/mobilitydata/gtfsvalidator/notice/NoticeSchemaGeneratorTest.java
Outdated
Show resolved
Hide resolved
lionel-nj
suggested changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aababilov, a few comments and suggestions in-line.
It is currently not plugged into cli/Main.java. The schema generator currently exports JSON schema for the notices. It may also export other schema formats in future (e.g., SQL-friendly schema). Sample output. ``` { "attribution_without_role": { "type": "object", "properties": { "attributionId": { "type": "string" }, "csvRowNumber": { "type": "integer" } } }, "block_trips_with_overlapping_stop_times": { "type": "object", "properties": { "blockId": { "type": "string" }, "csvRowNumberA": { "type": "integer" }, "csvRowNumberB": { "type": "integer" }, "intersection": { "type": "string" }, "serviceIdA": { "type": "string" }, "serviceIdB": { "type": "string" }, "tripIdA": { "type": "string" }, "tripIdB": { "type": "string" } } }, ```
41eb3ca
to
4f8ea9b
Compare
Thanks for review! |
lionel-nj
pushed a commit
that referenced
this pull request
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently not plugged into cli/Main.java.
The schema generator uses Java reflection to find all notice
classes and describe their fields.
The schema generator currently exports JSON schema for the notices. It
may also export other schema formats in future (e.g., SQL-friendly
schema).
Sample output.