feat: Implement ShapeToStopMatchingValidator #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aababilov
force-pushed
the
shape-to-stop-matching
branch
2 times, most recently
from
ed92803
to
535a527
Compare
|
This depends on #957 |
|
This also depends on #958 |
aababilov
force-pushed
the
shape-to-stop-matching
branch
from
535a527
to
895ab75
Compare
|
Closing and reopening to apply the workflow defined in #953 that aims at checking code formatting. |
|
Thanks @aababilov, I am currently reviewing the PR - could you fix the merge conflict please? |
It validates that stops match to shapes properly, mostly focusing on making sure that the stop sequences for trips that reference the shape can be properly matched to the shape. ShapeToStopMatchingValidator replaces StopTooFarFromTripShapeValidator. Dependency on spatial4j is removed. Now GTFS Validator upstream can be compiled at Google.
aababilov
force-pushed
the
shape-to-stop-matching
branch
from
895ab75
to
b11930f
Compare
|
All fixed and ready for review! |
lionel-nj
reviewed
Aug 17, 2021
core/src/main/java/org/mobilitydata/gtfsvalidator/util/MathUtil.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeToStopMatchingValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeToStopMatchingValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeToStopMatchingValidator.java
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeToStopMatchingValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeToStopMatchingValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeToStopMatchingValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeToStopMatchingValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/util/shape/StopToShapeMatcherSettings.java
Outdated
Show resolved
Hide resolved
7 tasks
lionel-nj
reviewed
Aug 19, 2021
main/src/main/java/org/mobilitydata/gtfsvalidator/util/shape/Assignment.java
Outdated
Show resolved
Hide resolved
lionel-nj
reviewed
Aug 19, 2021
main/src/main/java/org/mobilitydata/gtfsvalidator/util/shape/Problem.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/util/shape/Problem.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/util/shape/Problem.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/util/shape/ShapePoints.java
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/util/shape/ShapePoints.java
Show resolved
Hide resolved
| StopUtil.getStopOrParentLatLng(stopTable, stopTime.stopId()).toPoint(), | ||
| stopTime.shapeDistTraveled(), | ||
| stopTime, | ||
| stationSize.equals(StationSize.LARGE) && firstOrLastStop)); |
There was a problem hiding this comment.
Why considering firstOrLastStop here?
There was a problem hiding this comment.
Agency shapes often do not extend till the very end of the track, especially for train stations. Although this is a data issue that agencies should fix, we would like to be more tolerant and not drop such shapes completely.
There was a problem hiding this comment.
Thanks for the clarification!
main/src/test/java/org/mobilitydata/gtfsvalidator/util/shape/ShapePointsTest.java
Outdated
Show resolved
Hide resolved
|
Thanks for review! PTAL. |
lionel-nj
approved these changes
Aug 25, 2021
|
@aababilov great work! Thank you for this contribution! Sorry to be late at the party but could you please update RULES.md with those new rules? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It validates that stops match to shapes properly, mostly focusing on
making sure that the stop sequences for trips that reference the
shape can be properly matched to the shape.
ShapeToStopMatchingValidator replaces StopTooFarFromTripShapeValidator.
Dependency on spatial4j is removed. Now GTFS Validator consistently
uses the light-weight S2 Geometry library.