-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: StopZoneIdValidator #972
Conversation
- rework unit tests
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopZoneIdValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopZoneIdValidator.java
Outdated
Show resolved
Hide resolved
main/src/test/java/org/mobilitydata/gtfsvalidator/validator/StopZoneIdValidatorTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also recommend to add stopName field to the notice and pass GtfsStop as a parameter for convenience.
Honestly, I wonder why GTFS standard has this requirement this way. Why can't zone_id be provided for a station and apply to all child platforms? However, Google implementation agrees with the official GTFS description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor remark. Thanks a lot!
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopZoneIdValidator.java
Outdated
Show resolved
Hide resolved
Thanks for reviewing @aababilov! |
closes #950
Summary:
This PR provides support to check
STATION
orENTRANCE
inStopZoneIdValidator
.Expected behavior:
No notice should be generated for a record from
stops.txt
ifstop.zone_id
is empty ANDstops.location_type=1
orstops.location_type=2
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)