fix: StopZoneIdValidator #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rework unit tests
3 tasks
aababilov
reviewed
Aug 29, 2021
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopZoneIdValidator.java
Outdated
Show resolved
Hide resolved
isabelle-dr
approved these changes
Aug 30, 2021
aababilov
requested changes
Sep 2, 2021
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopZoneIdValidator.java
Outdated
Show resolved
Hide resolved
main/src/test/java/org/mobilitydata/gtfsvalidator/validator/StopZoneIdValidatorTest.java
Outdated
Show resolved
Hide resolved
aababilov
requested changes
Sep 2, 2021
There was a problem hiding this comment.
I also recommend to add stopName field to the notice and pass GtfsStop as a parameter for convenience.
Honestly, I wonder why GTFS standard has this requirement this way. Why can't zone_id be provided for a station and apply to all child platforms? However, Google implementation agrees with the official GTFS description.
aababilov
approved these changes
Sep 3, 2021
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopZoneIdValidator.java
Outdated
Show resolved
Hide resolved
|
Thanks for reviewing @aababilov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #950
Summary:
This PR provides support to check
STATIONorENTRANCEinStopZoneIdValidator.Expected behavior:
No notice should be generated for a record from
stops.txtifstop.zone_idis empty ANDstops.location_type=1orstops.location_type=2Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)