Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply sliding gesture colides with Android 11 back gesture #32

Closed
riedel opened this issue Oct 23, 2021 · 6 comments
Closed

Reply sliding gesture colides with Android 11 back gesture #32

riedel opened this issue Oct 23, 2021 · 6 comments
Labels
bug Something isn't working workaround available Something isn't working, but a workaround is available

Comments

@riedel
Copy link

riedel commented Oct 23, 2021

It is nearly impossible for me to use the app when using gesture navigation on Android 11. I always trigger a reply when I want to just go back. I have no clue how other apps handle this but glider is the first app where I see this problem and it is driving me crazy.

@Mosc
Copy link
Owner

Mosc commented Oct 25, 2021

That does sound very annoying. I don't tend to use gesture navigation myself, but enabling it, I can't get the issue you're describing to show up quite as reliably. I'd say swiping from the very right edge leftward will also trigger a reply swipe once out of every 10 attempts. Which is still not ideal. I'll have to look into this more.

@Mosc Mosc added the bug Something isn't working label Oct 25, 2021
@riedel
Copy link
Author

riedel commented Oct 26, 2021

Thanks for looking into this. Yes, both swipes are typically triggered, so this might be way to detect and resolve (cancel the reply if a simultaneous back event is detected). It is strange to me that sometimes I trigger reply in 8 of 10 cases while on other occasions it seems to be far less. I think it might have to do a lot with the device shape and the bumper case as this I think will have a direct effect on where exactly the finger hits first and on the timing. Another solution would be to only react to reply swipes starting further away from the edge. I do not know how practical such this are or if this is rather a framework issue.

@erahhal
Copy link

erahhal commented Nov 19, 2021

This is something that happens 100% of the time with me. It's also the first and only app I've seen this problem with.

Gmail has swipe right and left and it doesn't conflict, so either they've figured out how to cancel the in-app swipe gesture if there's a navigation swipe gesture registered, as suggested above, or they don't register the swipe if it comes from the very edge of the screen.

In any case, it's almost unusable as is. It's a nicely designed app and the best HN client I can find for Android besides this issue.

@Mosc
Copy link
Owner

Mosc commented Nov 19, 2021

It's not a perfect solution, but thanks to @shambu2k with his work on #38 you'll be able to disable gestures within the app entirely in the next release. This should at least be good enough to work around this issue.

It's interesting that the severity of the issue differs so much between users. I'm using gesture navigation on a new phone and I'd say this scenario occurs maybe once out of a hundred swipes.

@erahhal
Copy link

erahhal commented Nov 19, 2021

I have a OnePlus 7 pro with LineagoOS. I have a couple theories as to what might be making it worse:

  1. Custom OSes (e.g. OxygenOS that comes with OnePlus phones) have the swipe navigation finely tuned. AOSP distributions like Lineage are generic implementations of swipe often not tuned to the particular model.

  2. The OP7Pro has a curved screen, which makes swiping from the very edge super easy and typical. A Pixel with a flat screen and a thick case will cause the user to start a swipe further away from the edge, potentially making this problem occur less frequently.

@Mosc
Copy link
Owner

Mosc commented Mar 6, 2022

Closing this because while the bug still exists, it is a subset of the problem described in #36. Updates can be tracked there.

@Mosc Mosc closed this as completed Mar 6, 2022
@Mosc Mosc added the workaround available Something isn't working, but a workaround is available label Mar 6, 2022
@Mosc Mosc closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workaround available Something isn't working, but a workaround is available
Projects
None yet
Development

No branches or pull requests

3 participants