-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to turn off swipe navigation between pages #38
Conversation
I had envisioned this as a setting that disables all gestures, including swipes on item tiles (stories, comments, etc.) to fix #32 at the same time. Do you think that makes sense? |
Thanks for the contribution! |
Hmm yeah, makes sense. I only thought of SwipeablePageTransition as I never had issues with upvote or reply gestures. Will try to implement for other gestures. |
Now this fixes #32 too. Included option to toggle all gestures within the app in the settings bottom sheet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job on the implementation overall, just some minor details I'd like to see changed to fit my currently preferred style.
The CI build has failed on a few formatting issues. If your IDE doesn't automatically format the code, consider running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
A simple fix for issue #36. As mentioned, I have added an option to toggle the swipe to go back feature in the settings bottom sheet.
As of now, I have accessed the persistence provider in the app.dart file and passed the
bool useGestureNavigation
variable to the theme builders. Iffalse
,pageTransitionsTheme
is set tonull
which turns off the Swipeable page transition.