[BUGFIX] Allow @charset without error #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter out `@charset` at-rules from the CSS before processing, to avoid an error when presented with CSS containing this at-rule. Obviously this does not mean `@charset` is supported - its value is still ignored - but does address the immediate error in MyIntervals#296. Added PHPUnit test like that for `@import`, and also test that such CSS content does not prevent Emogrifier working correctly on the remainder of the CSS.
oliverklee
requested changes
Feb 8, 2018
tests/Unit/EmogrifierTest.php
Outdated
| * | ||
| * @dataProvider unneededCssThingsDataProvider | ||
| */ | ||
| public function emogrifyUnaffectedByUnneededCssThings($css) |
There was a problem hiding this comment.
Please let's rename the test to be more specific. What does "unaffected" mean?
(And please add a verb so that the test name is a (possible pidgin) sentence.)
There was a problem hiding this comment.
Have renamed the method.
oliverklee
approved these changes
Feb 8, 2018
|
Merged. Thanks for the bug fix, @JakeQZ! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out
@charsetat-rules from the CSS before processing, to avoid an errorwhen presented with CSS containing this at-rule.
Obviously this does not mean
@charsetis supported - its value is stillignored - but does address the immediate error in #296.
Added PHPUnit test like that for
@import, and also test that such CSS contentdoes not prevent Emogrifier working correctly on the remainder of the CSS.