-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to en-us when locale (intent, vocab) not found #2120
Comments
I agree that this should probably be done. I do think we should keep a mode where it'll error if not all translations are found to make it easy to see which ones aren't 100 % operational. I started the work on something like this this morning. hopefully a PR soonish :) |
This issue from mycroft-skills repo is related. |
When mycroft_skill.find_resource fails to load a resource for self.lang fall back to lang 'en-us' as most skills/resources are available in english by default. ==== Fixed Issues ==== MycroftAI#2120
When mycroft_skill.find_resource fails to load a resource for self.lang fall back to lang 'en-us' as most skills/resources are available in english by default. ==== Fixed Issues ==== MycroftAI#2120
Closed thanks to work by @domcross (probably got tired of waiting for the fix I was doing, I wonder where that branch went) |
When Skill-service starts up it loads all intents that are specified for a skill by looking into folders vocab/intent/locale for the configured language.
Problem: In case a intent/vocab-file is not found the skill is not loaded.
Example: recently the mycroft-stop skill was enhanced with the "reboot" intent. The "reboot.intent" file is currently only available for "en-us". I run Mycroft with
language="de-de"
and get following error:This renders the whole skill unusable for me...
Suggestion: when
load_skill
fails to load a intent/vocab-file fall back to "en-us" and try to load the intent again. As in 99.99% of all cases there is a english intent file this will not break the loading of the intent.The text was updated successfully, but these errors were encountered: