Commit per epoch config load to effects v2 #18501
Open
+120
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
lxfind
force-pushed
the
commit-config-to-effects
branch
from
6827992
to
f38a71c
Compare
mystenmark
reviewed
Jul 3, 2024
| @@ -595,4 +607,6 @@ pub enum UnchangedSharedKind { | |||
| ReadDeleted(SequenceNumber), | |||
| /// Shared objects in cancelled transaction. The sequence number embed cancellation reason. | |||
| Cancelled(SequenceNumber), | |||
| /// Read of a per-epoch config object that should remain the same during an epoch. | |||
| PerEpochConfig, | |||
There was a problem hiding this comment.
this requires a new protocol version, right?
There was a problem hiding this comment.
The per epoch config object is only checked when coin deny list v2 is enabled, and hence is already behind a new protocol version.
mystenmark
reviewed
Jul 3, 2024
| @@ -140,38 +141,43 @@ pub fn check_coin_deny_list_v2_during_execution( | |||
| .entry(coin_type.to_canonical_string(false)) | |||
| .or_insert_with(BTreeSet::new) | |||
| .insert(owner); | |||
| num_regulated_transfers += 1; | |||
There was a problem hiding this comment.
why is this incremented here, instead of after line 149?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commit per epoch config object load to effects.
This is done by introducing another variant to UnchangedSharedObject.
This does not need to be in input shared objects since it's not a sequenced input object.
This however does mean that this will not be added to the UnchangedSharedObject graphql rpc types since that relies on the input shared objects.
Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.