Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes authentication confusion #325

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Fixes authentication confusion #325

merged 1 commit into from
Nov 21, 2022

Conversation

apalha
Copy link
Contributor

@apalha apalha commented Nov 18, 2022

Sets the default authentication to ssh. The user is informed of this choice and provides information on how to use other forms of authentication.

Description
See above.

Related issues:

  • 289: authentication confusion when doing git push in next_steps.md

Instructions to review the pull request

Create a python-template-test repo on GitHub (will be overwritten if existing)

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
cookiecutter -c <pr-branch> https://github.com/<pr-user>/python-template
# Fill with python-template-test info
cd python-template-test
git init
git add --all
git commit -m "First commit"
git remote add origin https://github.com/<you>/python-template-test
git push -u origin main -f
python -m venv env
source env/bin/activate
python -m pip install --upgrade pip setuptools
python -m pip install '.[dev,publishing]'

Sets the default authentication to ssh. The user is informed of this choice and provides information on how to use other forms of authentication.
@egpbos
Copy link
Member

egpbos commented Nov 21, 2022

I approved the changes, but retriggered the GH Actions workflows, because three of them failed (Windows runs), let's see if they were intermittent failures. Did you check the failures @apalha? Were they related to this PR or something pre-existing?

@bvreede
Copy link
Member

bvreede commented Nov 21, 2022

I checked the links manually and they seem to work. Don't know why they fail but I've seen that before with this particular workflow...

@bvreede
Copy link
Member

bvreede commented Nov 21, 2022

Ah, I see it: the links are forwarding, so they work when clicked, but the workflow doesn't catch that.

I did miss that there were some tests failing 😬 don't know about that. It's Windows with Python 3.7 and up:

Edited:

It's an assertion error with this line (57-58) in test_project.py

    pip_output = run([f'{bin_dir}pip3', 'install', '--editable', '.[dev]'], result.project)
    assert pip_output.returncode == 0

This is the error message (as far as I can detect):

ERROR: Could not install packages due to an OSError: [WinError 5] Access is denied: 'c:\\hostedtoolcache\\windows\\python\\3.7.9\\x64\\lib\\site-packages\\~arkupsafe\\_speedups.cp37-win_amd64.pyd'
Consider using the `--user` option or check the permissions.

I propose moving this to a new issue and dealing with it separately.

@egpbos
Copy link
Member

egpbos commented Nov 21, 2022

@bvreede thanks for looking into that! Indeed deserves its own issue.

@egpbos egpbos merged commit 807f751 into main Nov 21, 2022
@egpbos egpbos linked an issue Nov 21, 2022 that may be closed by this pull request
@egpbos
Copy link
Member

egpbos commented Nov 21, 2022

@bvreede do you want to make the issue, or should I?

@bvreede
Copy link
Member

bvreede commented Nov 21, 2022

See #326 :)

@egpbos
Copy link
Member

egpbos commented Nov 21, 2022

Thanks!

@apalha
Copy link
Contributor Author

apalha commented Nov 21, 2022

Just saw this now. Yes, I saw the errors and they were triggered by older links. I see that you already noticed that. Thanks!

@sjvrijn sjvrijn deleted the 289-authentication-confusion branch February 8, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

authentication confusion when doing git push in next_steps.md
3 participants