Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python versions in CI matrix: -3.6, +3.10, +3.11 #329

Merged
merged 8 commits into from
Jan 31, 2023
Merged

Conversation

sjvrijn
Copy link
Contributor

@sjvrijn sjvrijn commented Jan 26, 2023

Description
Adds python 3.10 and 3.11 to the test matrix.

Related issues:

@egpbos
Copy link
Member

egpbos commented Jan 26, 2023

Oh dear, looks like CI is quite broken. Not your fault, but that makes it hard to review this...

@BSchilperoort
Copy link

BSchilperoort commented Jan 26, 2023

Oh dear, looks like CI is quite broken. Not your fault, but that makes it hard to review this...

From a quick search it seems to me this has to do with the pytest version being pinned to <5.0.0. The last update to 4.x was almost 3 years ago.

pytest<5.0.0,>=3.3.0

Tests of 3.7, 3.8 and 3.9 fail because of pyroma.

setup.py
  Line: None
    pyroma: PYRUNKNOWN / You should specify what Python versions you support with the 'requires-python'/'python_requires' metadata.

@sjvrijn sjvrijn changed the title Add python 3.10 and 3.11 to CI matrix Update python versions in CI matrix: -3.6, +3.10, +3.11 Jan 26, 2023
@egpbos
Copy link
Member

egpbos commented Jan 26, 2023

Thanks @BSchilperoort! Let's just remove the upper and lower limits then for pytest. The pyroma check should be fixed by adding python_requires = >=3.7 under [options] in setup.cfg, I think.

@egpbos
Copy link
Member

egpbos commented Jan 30, 2023

Argh
Schermafbeelding 2023-01-30 om 11 31 11

@sjvrijn
Copy link
Contributor Author

sjvrijn commented Jan 30, 2023

I'm finding all the interesting ways to break the CI it seems 😂

@egpbos
Copy link
Member

egpbos commented Jan 30, 2023

I guess the easiest fix here is to just wait two days for the (hopefully monthly) budget to be reset.

@egpbos
Copy link
Member

egpbos commented Jan 30, 2023

Well, actually you could try forking the repo and making the PR and running CI there to circumvent the nlesc org limits :)

@egpbos
Copy link
Member

egpbos commented Jan 31, 2023

All green, except the Windows builds, but that's already a separate issue: #326. Good to go!

@egpbos egpbos merged commit 21c9ed8 into main Jan 31, 2023
@sjvrijn sjvrijn deleted the python3.10-11 branch October 27, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants