Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumpversion bug #377

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Bumpversion bug #377

merged 2 commits into from
Apr 22, 2024

Conversation

f-hafner
Copy link
Contributor

Description

There has been a breaking change in bumpy-my-version. Instead of bump-my-version major, you need to do bump-my-version bump major, which I fixed in the tests and in the README.dev.md for the generated package.

See https://github.com/callowayproject/bump-my-version/blob/master/CHANGELOG.md#0190-2024-03-12

Instructions to review the pull request

Create a python-template-test repo on GitHub (will be overwritten if existing)

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
cookiecutter -c bumpversion-bug https://github.com/f-hafner/python-template
# Fill with python-template-test info
cd python-template-test
git init
git add --all
git commit -m "First commit"
git remote add origin https://github.com/<you>/python-template-test
git push -u origin main -f
python -m venv env
source env/bin/activate
python -m pip install --upgrade pip setuptools
python -m pip install '.[dev,publishing]'

@f-hafner f-hafner mentioned this pull request Mar 22, 2024
2 tasks
Copy link
Contributor

@sjvrijn sjvrijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sjvrijn
Copy link
Contributor

sjvrijn commented Apr 22, 2024

Markdown link checker only failed on a link that is now working again, merging

@sjvrijn sjvrijn merged commit 704a9b4 into NLeSC:main Apr 22, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants