Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused isort configuration #591

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Remove unused isort configuration #591

merged 2 commits into from
Aug 28, 2024

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Aug 27, 2024 •
edited
Loading

Checklist before requesting a review

  • I have read the contribution guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • All user facing changes have been added to CHANGELOG.md

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

List of related issues or pull requests**

None

Describe the changes made in this pull request

Remove unused isort configuration again since #392 seems to have gotten undone in #399.

@bouweandela bouweandela mentioned this pull request Aug 27, 2024
Open
3 tasks
@bouweandela bouweandela marked this pull request as ready for review August 27, 2024 13:29
@fdiblen fdiblen self-requested a review August 28, 2024 09:06
fdiblen
fdiblen approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @bouweandela. Thank you!
You can merge it ;)

@bouweandela bouweandela merged commit 953db45 into main Aug 28, 2024
18 checks passed
@bouweandela bouweandela deleted the remove-unused-isort-config branch August 28, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdiblen fdiblen fdiblen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bouweandela @fdiblen