Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

556-remove next_steps.md and show its content as a user message #609

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

fdiblen
Copy link
Member

@fdiblen fdiblen commented Aug 27, 2024

Checklist before requesting a review

  • I have read the contribution guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • All user facing changes have been added to CHANGELOG.md

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

List of related issues or pull requests**

Refs:

Describe the changes made in this pull request

This PR removes next_steps.md and shows a more concise version of it as a copier message. This message is only shown for 'recommended' and 'ask' profiles after the package is created.

Instructions to review the pull request

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Create a new package using the template

copier copy --vcs-ref 556_next_steps https://github.com/nlesc/python-template test_package

@fdiblen fdiblen marked this pull request as ready for review August 27, 2024 15:32
Copy link
Member

@lyashevska lyashevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Good to merge!

@fdiblen fdiblen merged commit eb1f02c into main Aug 27, 2024
18 checks passed
@fdiblen fdiblen deleted the 556_next_steps branch August 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants