Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Updating Examples #15

Merged
merged 9 commits into from
Nov 18, 2020
Merged

Updating Examples #15

merged 9 commits into from
Nov 18, 2020

Conversation

sourabhdalvi
Copy link
Contributor

No description provided.

Copy link
Member

@claytonpbarrows claytonpbarrows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are a couple things that might be worth cleaning. Also, you can run:

using SIIPExamples
SIIPExamples.literate_all(force=true)

to update the notebooks

@@ -111,9 +110,11 @@ solver = optimizer_with_attributes(Cbc.Optimizer, "logLevel" => 1, "ratioGap" =>
# ### Build an `OperationsProblem`
# The construction of an `OperationsProblem` essentially applies an `OperationsProblemTemplate`
# to `System` data to create a JuMP model.
horizon = 24 ; interval = Dates.Hour(24)
transform_single_time_series!(sys, horizon, interval)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sourabhdalvi @jd-lara is this something we should call in PSI automatically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you can have this automated in the simulation routine, if the system has just single time series then use the horizon and interval from simulation sequence to transform single time series.

@@ -33,8 +33,8 @@ solver = optimizer_with_attributes(Ipopt.Optimizer)
# For now, let's just choose a standard ACOPF formulation.
ed_template = template_economic_dispatch(network = ACPPowerModel)

# for some reason the HydroROR is currently incompatible with ACOPF. Bug report has been filed.
ed_template.devices[:HydroROR]= DeviceModel(HydroDispatch, HydroDispatchRunOfRiver)
# Currently energy budget data isn't stored in the RTS-GMLC dataset.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that you are changing the formulation for hydro here so that it doesn't use the budget formulation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to add the hydro_budget and storage_target time series data to use that formulation, so I changed it.

@sourabhdalvi sourabhdalvi marked this pull request as ready for review November 18, 2020 17:38
@claytonpbarrows claytonpbarrows merged commit bbb2df3 into master Nov 18, 2020
@claytonpbarrows claytonpbarrows deleted the sd/update_v1.0 branch November 18, 2020 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants