-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are a couple things that might be worth cleaning. Also, you can run:
using SIIPExamples
SIIPExamples.literate_all(force=true)
to update the notebooks
@@ -111,9 +110,11 @@ solver = optimizer_with_attributes(Cbc.Optimizer, "logLevel" => 1, "ratioGap" => | |||
# ### Build an `OperationsProblem` | |||
# The construction of an `OperationsProblem` essentially applies an `OperationsProblemTemplate` | |||
# to `System` data to create a JuMP model. | |||
horizon = 24 ; interval = Dates.Hour(24) | |||
transform_single_time_series!(sys, horizon, interval) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sourabhdalvi @jd-lara is this something we should call in PSI automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you can have this automated in the simulation routine, if the system has just single time series then use the horizon and interval from simulation sequence to transform single time series.
@@ -33,8 +33,8 @@ solver = optimizer_with_attributes(Ipopt.Optimizer) | |||
# For now, let's just choose a standard ACOPF formulation. | |||
ed_template = template_economic_dispatch(network = ACPPowerModel) | |||
|
|||
# for some reason the HydroROR is currently incompatible with ACOPF. Bug report has been filed. | |||
ed_template.devices[:HydroROR]= DeviceModel(HydroDispatch, HydroDispatchRunOfRiver) | |||
# Currently energy budget data isn't stored in the RTS-GMLC dataset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that you are changing the formulation for hydro here so that it doesn't use the budget formulation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need to add the hydro_budget
and storage_target
time series data to use that formulation, so I changed it.
No description provided.