This repository has been archived by the owner on May 16, 2023. It is now read-only.
Suppress logging #18
Merged
Suppress logging #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-thom
commented
Nov 22, 2020
|
|
||
| # ### Read and assign time series to `System` using the `ts_pointers` struct | ||
| add_time_series!(sys, ts_pointers) | ||
| # ### Read and assign time series to `System` using these parameters. |
There was a problem hiding this comment.
@claytonpbarrows IMHO it is better to keep this simpler. If you do want to expose the intermediate step to users, I'll revert the change.
There was a problem hiding this comment.
I think the same, there are too many intermediate steps here for this to be a tutorial
daniel-thom
commented
Nov 22, 2020
| to_json(sys, path) | ||
|
|
||
| filesize(path) / 1000000 #MB | ||
| filesize(path) / (1024 * 1024) #MiB |
There was a problem hiding this comment.
Tools like ls usually provide these sizes in base 2, not base 10. 1 Mebibyte = 2^20 bytes
jd-lara
approved these changes
Nov 22, 2020
There was a problem hiding this comment.
Thanks, @daniel-thom this will make the examples much better. I will see if the same works for the docs too.
claytonpbarrows
approved these changes
Nov 23, 2020
| @@ -42,7 +42,9 @@ Pkg.status() | |||
| using SIIPExamples; | |||
| using PowerSystems; | |||
| using D3TypeTrees; | |||
| IS = PowerSystems.IS | |||
| using Logging | |||
|
|
|||
There was a problem hiding this comment.
can we add something like the following:
# PowerSystems provides some control over log messages, [this doc page](https://nrel-siip.github.io/PowerSystems.jl/stable/api/public/#logging) provides more information about how to configure the logger.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to suppress
Infolog messages from showing up in the notebook. I think I heard from you guys that you would prefer this behavior. I made the changes in a subset of notebooks. If you agree with the changes then I'll continue with the rest.I also replaced JSON2 with JSON3.