Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Generate notebooks #39

Merged
merged 12 commits into from
Nov 1, 2021
Merged

Generate notebooks #39

merged 12 commits into from
Nov 1, 2021

Conversation

kdheepak
Copy link
Contributor

@kdheepak kdheepak commented Oct 14, 2021

Uses code from #37. Thanks to @ptn111 for the implementation.

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #39 (bb0179e) into master (db71f2f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #39   +/-   ##
======================================
  Coverage    7.52%   7.52%           
======================================
  Files           3       3           
  Lines          93      93           
======================================
  Hits            7       7           
  Misses         86      86           
Flag Coverage Δ
unittests 7.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4083fbf...bb0179e. Read the comment docs.

using SIIPExamples
using Literate

SIIPExamples.literate_all()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only create the notebook if the src .jl file has changed since the last time the notebook was written. Is it guaranteed that the notebooks don't exist when this runs. If not, I'd suggest using SIIPExamples.literate_all(force=true)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there are no notebooks in this repository. So no need to add force=true. But we can add it to be safe.

@claytonpbarrows claytonpbarrows merged commit bc40b4a into master Nov 1, 2021
@claytonpbarrows claytonpbarrows deleted the generate-notebooks branch November 1, 2021 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants