Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

update for PSID v0.8.0 #41

Merged
merged 1 commit into from
Nov 13, 2021
Merged

update for PSID v0.8.0 #41

merged 1 commit into from
Nov 13, 2021

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Nov 1, 2021

No description provided.


# This will automatically initialize the system by running a power flow
# and update `V_ref`, `P_ref` and hence `eq_p` (the internal voltage) to match the
# solution of the power flow. It will also initialize the states in the equilibrium,
# which can be printed with:
print_device_states(sim)
show_device_states(sim)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be show_states_initial_value(sim)

@@ -84,14 +83,15 @@ sim = PSID.Simulation(
# We can obtain the initial conditions as:

#Will print the initial states. It also give the symbols used to describe those states.
print_device_states(sim)
show_device_states(sim)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto: show_states_initial_value(sim)


# To examine the calculated initial conditions, we can export them into a dictionary:
x0_init = PSID.get_initial_conditions(sim)
x0_init = get_initial_conditions(sim)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We change it to read_initial_conditions(sim)

#Will export a dictionary with the initial condition values to explore
x0_init = PSID.get_initial_conditions(sim)
x0_init = get_initial_conditions(sim)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto: read_initial_conditions(sim)

#Will export a dictionary with the initial condition values to explore
x0_init_dyn = PSID.get_initial_conditions(sim_dyn)
x0_init_dyn = get_initial_conditions(sim_dyn)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto: read_initial_conditions(sim)

@@ -165,9 +162,9 @@ PSID.execute!(
# We can obtain the initial conditions as:

#Will print the initial states. It also give the symbols used to describe those states.
print_device_states(sim_dyn)
show_device_states(sim_dyn)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto: show_states_initial_value(sim)

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #41 (ae85a08) into master (db71f2f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #41   +/-   ##
======================================
  Coverage    7.52%   7.52%           
======================================
  Files           3       3           
  Lines          93      93           
======================================
  Hits            7       7           
  Misses         86      86           
Flag Coverage Δ
unittests 7.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4083fbf...ae85a08. Read the comment docs.

@claytonpbarrows claytonpbarrows merged commit 1e1f25f into master Nov 13, 2021
@claytonpbarrows claytonpbarrows deleted the jd/psid_examples_update branch November 13, 2021 20:22
@claytonpbarrows claytonpbarrows restored the jd/psid_examples_update branch November 17, 2021 17:22
@jd-lara jd-lara deleted the jd/psid_examples_update branch December 17, 2021 02:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants