Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Fix DataFrame creation in 08_US_system.jl #44

Merged
merged 3 commits into from
Dec 13, 2021

Conversation

josephmckinsey
Copy link

08_US_system.jl uses a very deprecated method to create a DataFrame. In DataFrames.jl 1.0, these methods were removed (JuliaData/DataFrames.jl#2679).

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #44 (8fbacaa) into master (6872368) will decrease coverage by 0.78%.
The diff coverage is n/a.

❗ Current head 8fbacaa differs from pull request most recent head 0157441. Consider uploading reports for the commit 0157441 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           master     #44      +/-   ##
=========================================
- Coverage    8.00%   7.21%   -0.79%     
=========================================
  Files           3       3              
  Lines         100      97       -3     
=========================================
- Hits            8       7       -1     
+ Misses         92      90       -2     
Flag Coverage Δ
unittests 7.21% <ø> (-0.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils.jl 21.21% <0.00%> (-2.32%) ⬇️
src/launch.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6872368...0157441. Read the comment docs.

Copy link
Member

@claytonpbarrows claytonpbarrows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@claytonpbarrows claytonpbarrows merged commit db7f642 into NREL-Sienna:master Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants