Create dockerfile

[haneslinger]

💚 docker start buildingmotif -i

root@235da402f95c:/# ls
bin  boot  buildingmotif  dev  etc  home  lib  lib64  media  mnt  opt  proc  root  run	sbin  srv  sys	tmp  usr  var

root@235da402f95c:/# cd buildingmotif/

root@235da402f95c:/buildingmotif# poetry run python
Skipping virtualenv creation, as specified in config file.
Python 3.8.15 (default, Oct 26 2022, 04:01:22) 
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from buildingmotif import BuildingMOTIF
>>> from buildingmotif.dataclasses import Model, Library
>>> 
>>> bm = BuildingMOTIF("sqlite://") # in-memory
>>> 
>>> lib = Library.load(ontology_graph="./libraries/brick/Brick-subset.ttl")   
>>> len(lib.get_templates())
824

[haneslinger]

@TShapinsky Great comments, addressed.

[TShapinsky]

@haneslinger I like where this is going. I'm not sure it makes sense to merge into develop right now since this seems to be for doing setup testing on rancher, right?

[haneslinger]

@TShapinsky, I mean, I don't see why we wouldn't push it, but I don't feel strongly about it.

[gtfierro]

Any reason why we wouldn't push?

[TShapinsky]

Any reason why we wouldn't push?

This is a good question. I don't have strong feelings about this particular PR. If people feel it makes sense to merge we can merge.

My general apprehension comes from trying to keep repository fairly clean by not adding things which aren't integral to the library. Right now we don't have any workflows or documentation which is applicable to the Dockerfile and by itself the container doesn't do anything, you have to open a terminal into it and start things manually. I don't see this as a deficiency of the Dockerfile as this is exactly what @haneslinger and I had talked about making, but it just seems of limited utility to anyone else at this point.

From the other side, it is a useful Dockerfile to have and easier for each of us to use if we have it merged. 🤷

[MatthewSteen]

LGTM. No preference on merging or not. Looks like Podman can use Dockerfiles, so that's something I'll probably try in the future.

[codecov-commenter]

Codecov Report

Base: 73.42% // Head: 73.54% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (88fe21b) compared to base (fc14b0f).
Patch coverage: 88.23% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #154      +/-   ##
===========================================
+ Coverage    73.42%   73.54%   +0.12%     
===========================================
  Files           31       31              
  Lines         2013     2026      +13     
===========================================
+ Hits          1478     1490      +12     
- Misses         535      536       +1     

Impacted Files	Coverage Δ
buildingmotif/api/app.py	81.81% <0.00%> (ø)
buildingmotif/database/utils.py	88.46% <91.66%> (+2.74%)	⬆️
buildingmotif/database/tables.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[TShapinsky]

Good to go once merge conflicts are resolved

[MatthewSteen]

Tried this with Podman and had one error. Haven't gotten it running yet but wanted to provide some intermediate feedback.