-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dockerfile #154
Create dockerfile #154
Conversation
haneslinger
commented
Oct 27, 2022
@TShapinsky Great comments, addressed. |
@haneslinger I like where this is going. I'm not sure it makes sense to merge into develop right now since this seems to be for doing setup testing on rancher, right? |
@TShapinsky, I mean, I don't see why we wouldn't push it, but I don't feel strongly about it. |
Any reason why we wouldn't push? |
This is a good question. I don't have strong feelings about this particular PR. If people feel it makes sense to merge we can merge. My general apprehension comes from trying to keep repository fairly clean by not adding things which aren't integral to the library. Right now we don't have any workflows or documentation which is applicable to the From the other side, it is a useful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No preference on merging or not. Looks like Podman can use Dockerfiles, so that's something I'll probably try in the future.
Codecov ReportBase: 73.42% // Head: 73.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #154 +/- ##
===========================================
+ Coverage 73.42% 73.54% +0.12%
===========================================
Files 31 31
Lines 2013 2026 +13
===========================================
+ Hits 1478 1490 +12
- Misses 535 536 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go once merge conflicts are resolved
b089856
to
ec6842d
Compare
…t-in sqlalchemy JSON type based on the chosen db dialect
ec6842d
to
df49dcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried this with Podman and had one error. Haven't gotten it running yet but wanted to provide some intermediate feedback.