Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shape collection to model #228

Merged
merged 9 commits into from
Apr 3, 2023
Merged

Add shape collection to model #228

merged 9 commits into from
Apr 3, 2023

Conversation

haneslinger
Copy link
Collaborator

No description provided.

@TShapinsky TShapinsky force-pushed the Add-shape-collection-to-model branch from 1148b8b to 5d1cdd2 Compare March 6, 2023 22:51
@haneslinger
Copy link
Collaborator Author

@haneslinger change model.shape_collection to model.manifest

@haneslinger haneslinger force-pushed the Add-shape-collection-to-model branch from f51abba to 71910b4 Compare March 22, 2023 22:22
haneslinger
haneslinger commented Mar 23, 2023
View reviewed changes
notebooks/GabeDemo.ipynb Outdated Show resolved Hide resolved
@haneslinger
Copy link
Collaborator Author

@gtfierro Any idea why the tests would start failing?
https://pipelines.actions.githubusercontent.com/serviceHosts/9dcdc121-107e-4bdf-8dde-a775c5259344/_apis/pipelines/1/runs/1556/signedlogcontent/15?urlExpires=2023-03-23T21%3A19%3A30.5657853Z&urlSigningMethod=HMACV1&urlSignature=2xZt8neqiDx8st2G41EDF22fOpAayhl6VUqOrSg%2BufY%3D

@gtfierro
Copy link
Collaborator

Have you merged from develop? Looks like this is related to the 223P stuff, which I did make some changes on recently.

@haneslinger
Copy link
Collaborator Author

Have you merged from develop? Looks like this is related to the 223P stuff, which I did make some changes on recently.

yes, what's more, test-manifest is this branch but rebased off develop. Still fails

@gtfierro gtfierro mentioned this pull request Apr 3, 2023
Merged
1 task
@gtfierro gtfierro merged commit d5c0537 into develop Apr 3, 2023
@gtfierro gtfierro deleted the Add-shape-collection-to-model branch April 3, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TShapinsky TShapinsky TShapinsky left review comments

@gtfierro gtfierro gtfierro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haneslinger @gtfierro @TShapinsky