Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress documentation #229

Merged
merged 14 commits into from
Apr 12, 2023
Merged

Ingress documentation #229

merged 14 commits into from
Apr 12, 2023

Conversation

gtfierro
Copy link
Collaborator

@gtfierro gtfierro commented Mar 8, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (12ebb4e) 72.75% compared to head (6883bed) 72.75%.

❗ Current head 6883bed differs from pull request most recent head f940be0. Consider uploading reports for the commit f940be0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #229   +/-   ##
========================================
  Coverage    72.75%   72.75%           
========================================
  Files           32       32           
  Lines         2063     2063           
========================================
  Hits          1501     1501           
  Misses         562      562           
Impacted Files Coverage Δ
buildingmotif/ingresses/base.py 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/guides/ingress.md Outdated Show resolved Hide resolved
docs/guides/ingress.md Outdated Show resolved Hide resolved
docs/guides/ingress.md Outdated Show resolved Hide resolved
docs/guides/ingress.md Outdated Show resolved Hide resolved
docs/guides/ingress.md Outdated Show resolved Hide resolved
@gtfierro gtfierro marked this pull request as ready for review March 23, 2023 21:57
Copy link
Member

@MatthewSteen MatthewSteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few organizational comments.

Handler vs. Manager? See #14 (comment). I'm not sure what's a better name and know handler is frequently used but I like manager more for some reason. Thoughts? Not sure if there's a best practice or reference for this.

docs/_toc.yml Outdated Show resolved Hide resolved
docs/guides/ingress.md Outdated Show resolved Hide resolved
docs/guides/ingress.md Outdated Show resolved Hide resolved
@MatthewSteen MatthewSteen added the documentation Improvements or additions to documentation label Mar 24, 2023
@gtfierro
Copy link
Collaborator Author

Looking good! Just a few organizational comments.

Handler vs. Manager? See #14 (comment). I'm not sure what's a better name and know handler is frequently used but I like manager more for some reason. Thoughts? Not sure if there's a best practice or reference for this.

"Manager" was doing something different there. I like the word "handler" here because it is handling the receipt of information and processing it; it is not mediating or managing access to that information

@MatthewSteen MatthewSteen merged commit 13be650 into develop Apr 12, 2023
@MatthewSteen MatthewSteen deleted the gtf-ingress-docs branch April 12, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants