-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingress documentation #229
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #229 +/- ##
========================================
Coverage 72.75% 72.75%
========================================
Files 32 32
Lines 2063 2063
========================================
Hits 1501 1501
Misses 562 562
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few organizational comments.
Handler vs. Manager? See #14 (comment). I'm not sure what's a better name and know handler
is frequently used but I like manager
more for some reason. Thoughts? Not sure if there's a best practice or reference for this.
"Manager" was doing something different there. I like the word "handler" here because it is handling the receipt of information and processing it; it is not mediating or managing access to that information |
No description provided.