-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate template in model UI #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good Hannah. I think we'll probably have some questions in the future about what exactly we want certain strings to be in the UI. But, I think it's more important to get this PR merged soon. What is the status of the model namespace prepending when evaluating a template in the UI? Is that something which was intended for this PR or for a future one?
buildingmotif-app/src/app/template-evaluate/template-evaluate.component.ts
Outdated
Show resolved
Hide resolved
We can add it in this PR- I'm just not sure how to do it...
|
I think minimally that's about is, there's still a question about the separator. Maybe just use a |
9837b54
to
549e2ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the mistake I made this looks good to me, @haneslinger
This passes locally 😿 |
Moves the evaluate ui to the model detail page.
![image](https://user-images.githubusercontent.com/30241543/226764969-c9c8e6c8-012d-46cd-bc9d-800b21bef1d1.png)
![image](https://user-images.githubusercontent.com/30241543/226764989-aad25cb1-493e-4a3a-bf48-c38a514b2722.png)
![image](https://user-images.githubusercontent.com/30241543/226765027-1021a3ea-b52d-46ea-ac2f-c278c946076b.png)