Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate template in model UI #232

Merged
merged 6 commits into from
Apr 18, 2023
Merged

Evaluate template in model UI #232

merged 6 commits into from
Apr 18, 2023

Conversation

haneslinger
Copy link
Collaborator

Moves the evaluate ui to the model detail page.
image
image
image

Copy link
Member

@TShapinsky TShapinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good Hannah. I think we'll probably have some questions in the future about what exactly we want certain strings to be in the UI. But, I think it's more important to get this PR merged soon. What is the status of the model namespace prepending when evaluating a template in the UI? Is that something which was intended for this PR or for a future one?

@haneslinger
Copy link
Collaborator Author

What is the status of the model namespace prepending when evaluating a template in the UI? Is that something which was intended for this PR or for a future one?

We can add it in this PR- I'm just not sure how to do it...
it's just this?

bindings = {k: model.name + v for k,v in bindings.items()}

@TShapinsky
Copy link
Member

What is the status of the model namespace prepending when evaluating a template in the UI? Is that something which was intended for this PR or for a future one?

We can add it in this PR- I'm just not sure how to do it... it's just this?

bindings = {k: model.name + v for k,v in bindings.items()}

I think minimally that's about is, there's still a question about the separator. Maybe just use a / for now

@haneslinger haneslinger changed the base branch from validate-on-shapes to develop April 17, 2023 16:54
Copy link
Member

@TShapinsky TShapinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the mistake I made this looks good to me, @haneslinger

@haneslinger
Copy link
Collaborator Author

This passes locally 😿

@haneslinger haneslinger merged commit e9b5f2b into develop Apr 18, 2023
@haneslinger haneslinger deleted the evaluate-in-model-UI branch April 18, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants