Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BACnet scan to CLI #242

Merged
merged 18 commits into from
Jun 30, 2023
Merged

Add BACnet scan to CLI #242

merged 18 commits into from
Jun 30, 2023

Conversation

TShapinsky
Copy link
Member

@TShapinsky TShapinsky commented May 16, 2023

  • Add buildingmotif scan command which intercepts the records and saves them to a JSON
  • Added generic dumping and loading for Record Ingress Handlers

@TShapinsky TShapinsky requested a review from gtfierro May 16, 2023 18:57
@TShapinsky
Copy link
Member Author

@gtfierro It appears to be having trouble binding to the address for the bacnet scan. Any ideas? I've had this issue a lot with the bacnet stuff on other platforms.

@gtfierro
Copy link
Collaborator

@gtfierro It appears to be having trouble binding to the address for the bacnet scan. Any ideas? I've had this issue a lot with the bacnet stuff on other platforms.

My guess is we aren't doing sufficient cleanup from another BACnet test?

Copy link
Collaborator

@gtfierro gtfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change to make, otherwise this looks great!

buildingmotif/ingresses/bacnet.py Outdated Show resolved Hide resolved
@gtfierro gtfierro linked an issue Jun 13, 2023 that may be closed by this pull request
@TShapinsky TShapinsky merged commit d5bd920 into develop Jun 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BACnet CLI scanning Utility
2 participants