Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker docs #276

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Add docker docs #276

merged 4 commits into from
Sep 11, 2023

Conversation

haneslinger
Copy link
Collaborator

docs/reference/developer_documentation.md Outdated Show resolved Hide resolved
docs/reference/developer_documentation.md Outdated Show resolved Hide resolved
Copy link
Member

@TShapinsky TShapinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, just one comment

docs/reference/developer_documentation.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@gtfierro gtfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just fix @TShapinsky's comment (either 127.0.0.1 or localhost is fine as long as we are consistent w/n this document)

@gtfierro gtfierro self-requested a review September 11, 2023 17:42
@haneslinger haneslinger merged commit c0065e5 into develop Sep 11, 2023
2 checks passed
@haneslinger haneslinger deleted the Add-docker-documentation branch September 11, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants