Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manifest docs #277

Merged
merged 15 commits into from
Sep 11, 2023
Merged

Fix manifest docs #277

merged 15 commits into from
Sep 11, 2023

Conversation

gtfierro
Copy link
Collaborator

Fixes #269

Required adding a few flags to the validation process to properly handle edge cases. These are covered in the unit tests as well

buildingmotif/dataclasses/model.py Outdated Show resolved Hide resolved
buildingmotif/dataclasses/shape_collection.py Show resolved Hide resolved
buildingmotif/dataclasses/model.py Outdated Show resolved Hide resolved
Copy link
Member

@TShapinsky TShapinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gtfierro gtfierro merged commit 39c7671 into develop Sep 11, 2023
7 checks passed
@gtfierro gtfierro deleted the gtf-fix-manifest-docs branch September 11, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update manifest usage style in guides
2 participants