Update 223P to public advisory review version #309
+392,170
−89,991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beta release
…OTIF into gtf-update-223p-templates
…ugment tests to check both shacl engines
|
@TShapinsky I think this is finally ready for review! |
TShapinsky
reviewed
Jul 5, 2024
|
|
||
| # non-singleton BuildingMOTIF | ||
| class BuildingMOTIF: | ||
| """Manages BuildingMOTIF data classes.""" |
There was a problem hiding this comment.
I think this can be avoided by the following:
You can create multiple instances of BuildingMOTIF if you call BuildingMOTIF.clean() between each constructor call. This only deletes the current instance from the class object, you can still keep it and do stuff with it.
There was a problem hiding this comment.
One additional thing I just thought of, you may be able to avoid the monkeypatch stuff for get_building_motif by just setting the instance attribute on the BuildingMOTIF class to the one you want to use.
|
Looks good, @gtfierro. I have a couple more comments, but hopefully that should be it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a whole mess of changes in here, sorry! I'll summarize them here:
pyshacl; working out how we can still test the pyshacl stuff)TODO: