fix tests for windows #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtfierro
requested changes
May 22, 2024
dllliu
commented
Jul 1, 2024
|
@MatthewSteen you develop mostly on Windows, right? Can you give this a test on your machine to see if it works? |
Windows machine, but this repo in on the Ubuntu 22 side. I'll take a look. |
|
Passes on WSL but I'm not sure if that confirms anything. I think if it passes on Daniel's Windows machine (not WSL), then the issue could be considered fixed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add delete=false parameter to temporary file objects in order to fix permission denied errors when running unit tests for windows and flush buffer in memory after data is written and before new data is written in order to fix invalid zip file errors