Fix ASAN build #5492
Merged
Fix ASAN build #5492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI MESSAGE: [15429280]: BUILD STARTED |
|
CI MESSAGE: [15429280]: BUILD FAILED |
jantonguirao
force-pushed
the
asan_build_video_plugin
branch
from
6a69438
to
e1cda97
Compare
|
CI MESSAGE: [15433058]: BUILD STARTED |
|
CI MESSAGE: [15433058]: BUILD FAILED |
jantonguirao
force-pushed
the
asan_build_video_plugin
branch
from
e1cda97
to
bcf2b5f
Compare
|
CI MESSAGE: [15437625]: BUILD STARTED |
|
CI MESSAGE: [15437625]: BUILD FAILED |
Signed-off-by: Joaquin Anton <[email protected]>
jantonguirao
force-pushed
the
asan_build_video_plugin
branch
from
bcf2b5f
to
ca5583f
Compare
szkarpinski
reviewed
May 31, 2024
plugins/video/pkg_src/CMakeLists.txt
Outdated
| else() | ||
| set(NEW_LD_PRELOAD "${cuda_LIBRARY}") | ||
| endif() | ||
| string(REPLACE " " ":" NEW_LD_PRELOAD "${NEW_LD_PRELOAD}") |
There was a problem hiding this comment.
Why can't we just set(NEW_LD_PRELOAD "$ENV{LD_PRELOAD}:${cuda_LIBRARY}") to have the colon already there? Also, this will break if somebody has a space in their LD_PRELOAD or cuda path/
There was a problem hiding this comment.
the thing is that the LD_PRELOAD has a space, and my command below doesn't like it. So I am using an alternative way to separate paths.
Signed-off-by: Joaquin Anton <[email protected]>
|
CI MESSAGE: [15459175]: BUILD STARTED |
szkarpinski
approved these changes
May 31, 2024
stiepan
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other Fixes tests with sanitizer builds
Description:
Correctly propagate LD_PRELOAD arguments passed prior to installing the DALI video plugin
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A