Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default schema and use it in OpSpec argument queries. #5500

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Jun 5, 2024

Category:

New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description:

Prior to this change it was possible to construct an OpSpec with a name of a nonexistent schema, but it was impossible to query it for arguments - even ones that were present in the OpSpec.
This change introduces a default schema which is used in argument queries in absence of a proper schema. This gives consistent results when querying for default values of built-in arguments.

Additional information:

Affected modules and functionalities:

OpSpec::[Try]Get[Repeated]Argument

Key points relevant for the review:

Tests:

OpSpecTest.EmptySchema

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Michal Zientkiewicz <[email protected]>
@NVIDIA NVIDIA deleted a comment from dali-automaton Jun 5, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15587038]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15587038]: BUILD PASSED

@mzient mzient merged commit df89b7e into NVIDIA:main Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants