Fix broken link to nasm source in the deps docker #5517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantonguirao
approved these changes
Jun 11, 2024
Signed-off-by: Kamil Tokarski <[email protected]>
stiepan
force-pushed
the
fix_nasm_broken_link
branch
from
b0b5e90
to
f020859
Compare
|
CI MESSAGE: [15736061]: BUILD STARTED |
mzient
reviewed
Jun 11, 2024
mzient
approved these changes
Jun 11, 2024
|
CI MESSAGE: [15736061]: BUILD FAILED |
Signed-off-by: Kamil Tokarski <[email protected]>
|
CI MESSAGE: [15738256]: BUILD STARTED |
stiepan
changed the title
|
CI MESSAGE: [15738256]: BUILD FAILED |
mzient
reviewed
Jun 12, 2024
| make install | ||
| make install && \ | ||
| popd && \ | ||
| rm -rf nasm-nasm-2.15.05/ nasm-2.15.05.tar.gz |
There was a problem hiding this comment.
Why do we bother cleaning stuff from /tmp in docker?
|
CI MESSAGE: [15738256]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
The previous link is down.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A