Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix converter defautl args #9565

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Conversation

akoumpa
Copy link
Collaborator

@akoumpa akoumpa commented Jun 28, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@akoumpa akoumpa marked this pull request as ready for review June 28, 2024 16:07
@akoumpa akoumpa self-assigned this Jun 28, 2024
@akoumpa akoumpa added the NLP label Jun 28, 2024
@github-actions github-actions bot removed the NLP label Jun 28, 2024
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the akoumparouli/mixtral_converter_fix branch from e716d62 to ad3e375 Compare June 28, 2024 16:08
@github-actions github-actions bot removed the NLP label Jun 28, 2024
@akoumpa akoumpa requested a review from marcromeyn July 4, 2024 19:22
@akoumpa akoumpa added Run CICD and removed Run CICD labels Jul 5, 2024
@akoumpa akoumpa merged commit 10768ae into main Jul 5, 2024
115 checks passed
@akoumpa akoumpa deleted the akoumparouli/mixtral_converter_fix branch July 5, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants