Fix nmt weight conversion #1660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pzzzzz5142
force-pushed
the
dev-pzzzzz-fix-nmt-convert
branch
from
132468e
to
53023c5
Compare
|
Thank you for the report. We will fix it soon. |
Merged
|
Closing this pr since the changes are included in the main branch. |
|
Thank you for the contribution. We have add you into the co-author into the release note. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For WMT14 model, it shares the vocab across the encoder and decoder. So it wouldn't trigger this error. However, for language pair which has large differences like zh-en, usually we don't share the vocab. So here we need set the vocab size for decoder correctly.