[GEMMA] from_hugging_face not setting share_embedding_table to True leading to incapacity to load Gemma
#1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coming from `from_hugging_face` doesn't set this parameter.
|
@mfuntowicz Thanks for your contribution to TRT-LLM, we'll take a look this change firstly. |
|
Opening an internal MR for that. |
|
Hi @mfuntowicz , thanks for your contribution, we've merged your changes into our internal code base and will upstream to main branch next week |
Merged
|
Hi @mfuntowicz , the main branch has been updated with your changes integrated, thanks a lot for your contribution. I'm closing this PR, please let us know if there are any questions. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gemma requires
shared_embedding_tableto beTruebut coming fromfrom_hugging_facedoesn't set this parameter.