This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Add support for clang-16 #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
approved these changes
Mar 28, 2023
miscco
reviewed
Mar 28, 2023
Comment on lines
-47
to
-50
| comment "Install GCC and Clang"; \ | ||
| # Unattended installation hack | ||
| if [ "${USE_LLVM_INSTALLER}" -eq "1" ]; then echo "\n" | bash /tmp/llvm.sh all; fi; \ | ||
| ${APT_GET} install gcc g++ ${COMPILERS}; \ |
There was a problem hiding this comment.
Is there a reason we cannot extract the version of clang and do
comment "Install GCC and Clang"; \
# Unattended installation hack
if [ "${USE_LLVM_INSTALLER}" -eq "1" ]; then echo "\n" | bash /tmp/llvm.sh CLANG-VERSION; fi; \
if [ "${USE_LLVM_INSTALLER}" -eq "1" ]; then echo "\n" | bash /tmp/llvm.sh 16; fi; \
${APT_GET} install gcc g++ ${COMPILERS}; \
There was a problem hiding this comment.
Wouldn't work on older images as I think llvm installer only supports up to llvm-9.
We can investigate changing this when clang-17 shows up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.