Fixed GetContainedCharacterIndexFromPos accessing invalid index ^& crash

Neko-Box-Coder · May 5, 2023 · bec0af3 · bec0af3
1 parent 8217d29
commit bec0af3
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/Src/ssGUI/GUIObjectClasses/Text.cpp b/Src/ssGUI/GUIObjectClasses/Text.cpp
@@ -1861,6 +1861,9 @@ namespace ssGUI
         //TODO: Add max search iterations
         while (true)
         {
+            if(endIndex < startIndex)
+                return -1;
+
             //Check start and end index are valid
             while (!CharactersRenderInfos[startIndex].Valid && startIndex < CharactersRenderInfos.size()) 
             {
@@ -1889,6 +1892,9 @@ namespace ssGUI
                 return midIndex;
             }
 
+            if(endIndex <= startIndex)
+                return -1;
+
             ssGUI::CharacterRenderInfo& startInfo = CharactersRenderInfos[startIndex];
             ssGUI::CharacterRenderInfo& endInfo = CharactersRenderInfos[endIndex];