Add conj for QQFieldElem and ZZRingElem #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1827 +/- ##
==========================================
- Coverage 86.08% 86.06% -0.03%
==========================================
Files 98 98
Lines 36398 36404 +6
==========================================
- Hits 31334 31331 -3
- Misses 5064 5073 +9 ☔ View full report in Codecov by Sentry. |
|
As I wrote in oscar-system/Oscar.jl#3342 (comment), I am happy adding it to things which are "contained" in the complex numbers. I don't see a reason to add it to polynomials etc. at the moment. Maybe I am being overly cautious? |
|
@thofma sorry I missed your comment there. I've adjusted this PR now |
fingolfin
changed the title
thofma
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.