Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: merging of two similarly keyed mappings #11

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

StummeJ
Copy link
Contributor

@StummeJ StummeJ commented Nov 8, 2023

Overview

This sets out to fix issue #10. We found that merging two sources with similar mappings would cause the destruction of the mapping from the previously processed source. The use case we found this in was having a config with some secret values, then populating just the secret values from a secure store.

Specifics

  • Add deepmerge package to handle merging of two mappings properly
  • Add some additional typing for added type safety
  • Fix a test that would fail due to vscode using TEST_ environment variables for it's test runner

@RobertoPrevato
Copy link
Member

Hi @StummeJ
I apologize for replying so late, I appreciate this very much and I am willing to merge and release a new package with this feature.

@RobertoPrevato RobertoPrevato merged commit 0eb8115 into Neoteroi:main Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants