Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Account package - test case set #215

Closed
rianhughes opened this issue Jun 28, 2023 · 4 comments
Closed

[Test] Account package - test case set #215

rianhughes opened this issue Jun 28, 2023 · 4 comments
Labels
Milestone

Comments

@rianhughes
Copy link
Contributor

Fix tests in the contracts folder

@rianhughes
Copy link
Contributor Author

@stranger80 stranger80 changed the title Fix tests - contracts [Test] Fix tests - contracts Sep 25, 2023
@rianhughes
Copy link
Contributor Author

Should we just absorb this into the accounts package, by making the contract-methods methods of the accounts pkg?

@stranger80 stranger80 changed the title [Test] Fix tests - contracts [Test] Account package - test case set Sep 26, 2023
@stranger80
Copy link
Contributor

stranger80 commented Sep 26, 2023

Let's rename this one, and assume this includes creating a "sensible" test case set for account package. Recommended to include a sample of Cairo 2.x contract code and operate on that contract code sample to prove it works with Starknet.go.

This test suite shall include:

  • Declare Cairo contract to the network
  • Unit test for methods moved from "contracts" folder (eg WaitForTransaction())

Note: it may be sensible to have a single set of Cairo code "Assets"/artifacts, and refer to them from test cases, as well as library examples (in /examples folder).

@stranger80 stranger80 added this to the v0.4.6 milestone Oct 3, 2023
@cicr99
Copy link
Contributor

cicr99 commented Oct 9, 2023

@cicr99 cicr99 closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants