Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New account #302

Merged
merged 69 commits into from
Oct 2, 2023
Merged

New account #302

merged 69 commits into from
Oct 2, 2023

Conversation

rianhughes
Copy link
Contributor

@rianhughes rianhughes commented Aug 30, 2023 •
edited
Loading

@rianhughes rianhughes self-assigned this Aug 30, 2023
@rianhughes rianhughes marked this pull request as draft September 11, 2023 07:06
@rianhughes rianhughes mentioned this pull request Sep 14, 2023
Closed
@rianhughes rianhughes mentioned this pull request Sep 26, 2023
Closed
@rianhughes rianhughes mentioned this pull request Sep 26, 2023
Closed
@rianhughes rianhughes mentioned this pull request Sep 26, 2023
Closed
@rianhughes rianhughes requested review from kirugan and removed request for 0xcoburn September 26, 2023 09:14
kirugan
kirugan reviewed Sep 28, 2023
View reviewed changes
.github/workflows/test_account.yml Outdated Show resolved Hide resolved
utils/Felt.go Outdated Show resolved Hide resolved
utils/Felt.go Outdated Show resolved Hide resolved
utils/Test.go Outdated Show resolved Hide resolved
rpc/types_transaction_interfaces.go Show resolved Hide resolved
account/hash.go Outdated Show resolved Hide resolved
cicr99
cicr99 reviewed Sep 29, 2023
View reviewed changes
account/account.go Show resolved Hide resolved
account/account.go Outdated Show resolved Hide resolved
account/account.go Outdated Show resolved Hide resolved
account/account.go Outdated Show resolved Hide resolved
account/account_test.go Outdated Show resolved Hide resolved
account/account_test.go Outdated Show resolved Hide resolved
account/account_test.go Outdated Show resolved Hide resolved
@cicr99 cicr99 mentioned this pull request Sep 29, 2023
Merged
cicr99
cicr99 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@cicr99 cicr99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cicr99 cicr99 merged commit 042eb1e into main Oct 2, 2023
2 of 4 checks passed
@cicr99 cicr99 deleted the new-account branch October 2, 2023 15:10
@cicr99 cicr99 mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirugan kirugan kirugan left review comments

@0xcoburn 0xcoburn 0xcoburn approved these changes

@cicr99 cicr99 cicr99 approved these changes

Assignees

@rianhughes rianhughes

Labels
Account
Projects
[Nubia] Starknet.go
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rianhughes @kirugan @0xcoburn @cicr99