Add example for creating pixel mask to ophys tutorial (inspired by #572) #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bendichter |
Yeah, the message implies that pynwb is using 2.7.0 by default. |
bendichter
reviewed
Jul 8, 2024
bendichter
reviewed
Jul 27, 2024
tutorials/html/ophys.html
Outdated
| plane_segmentation = types.core.PlaneSegmentation( ... | ||
| 'colnames', {'pixel_mask'}, ... | ||
| 'description', 'roi pixel position (x,y) and pixel weight', ... | ||
| 'id', types.hdmf_common.ElementIdentifiers('data', int64(0:n_rois-1)'), ... |
There was a problem hiding this comment.
Suggested change
| 'id', types.hdmf_common.ElementIdentifiers('data', int64(0:n_rois-1)'), ... |
this line is no longer needed. If 'id' is omitted, it will be added automatically.
|
@ehennestad this looks great! Just one minor edit, then it's good to go |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It was unclear how to create pixel_mask for PlaneSegmentation objects. This was raised in issue #572
How to test the behavior?
Checklist
fix #XXwhereXXis the issue number?