-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try using node installed from conda #902
Conversation
GitHub Actions now passes |
OK, I'll let you play around with it a bit more If we can't get it working within a few days though, I think we should just go ahead and cut a new release - would you be able to build and sign the mac ones yourself in that event? |
Yes, can do. |
I think I figured it out. The issue is due to puppeteer. I see two options to resolve this: Option 1: update Puppeteer to v22 (ref) Option 2: use I think we might as well update in Option 1. Second question: I updated node, npm, electron packages, and vite. I looked through the electron release notes and saw nothing breaking that affects GUIDE. Vite 5 says |
Tests are failing. I spoke too soon. Will investigate tomorrow. |
Could be random failures, sometimes retries are necessary So strange that some platforms do complete just fine. Have you tested it completely locally using a completely fresh node install? |
Although making that many updates to the |
@rly Another thought was that we could break a part the pieces of the testing suite even more across the CI, and have the base level tests run pytest/vitetest, and have end to end tests through puppeteer as an entirely separate workflow (then that would be the only one have issues) On top of that, we could just do a targetted install of puppeteer in its own workflow rather than as a part of the broader package Can discuss more at meeting today - WDYT? |
Just to recap our meeting:
On top of that, we could just do a targetted install of puppeteer in its own workflow rather than as a part of the broader package" -- I agree. I'll work on that.
I'll get to these around the end of the week. |
@rly Good to close? |
the workflows first use conda to install node 18. then they install node 20. this might result in conflicts. https://stackoverflow.com/questions/41524903/why-is-npm-install-really-slow
testing:
do not install node 20.