Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated ndx-icephys-meta schema with NWB core #470

Merged
merged 12 commits into from
Jul 20, 2021
Merged

Integrated ndx-icephys-meta schema with NWB core #470

merged 12 commits into from
Jul 20, 2021

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Apr 5, 2021 •
edited
Loading

This PR is for integration of the ndx-icephys-meta structures with NWB core.

List of completed items:

  • Declared SweepTable as deprecated
  • Declared icephys filtering field deprecatd
  • Integrated the new types from the ndx-icephys-meta extensions schema
    • TimeSeriesReferenceVectorData
    • IntracellularRecordingsTable
    • SimultaneousRecordingsTable
    • SequentialRecordingsTable
    • RepetitionsTable
    • ExperimentalConditionsTable
  • Added new icephys tables to NWBFile as part of /general/icephys

@oruebel oruebel requested review from rly and ajtritt April 5, 2021 19:20
@oruebel oruebel mentioned this pull request Apr 5, 2021
Merged
26 tasks
@oruebel oruebel marked this pull request as ready for review April 13, 2021 16:35
@oruebel
Copy link
Contributor Author

oruebel commented Apr 13, 2021

@rly @ajtritt this PR is ready for review

oruebel
oruebel commented Apr 28, 2021
View reviewed changes
core/nwb.icephys.yaml Outdated Show resolved Hide resolved
rly
rly reviewed Jun 11, 2021
View reviewed changes
core/nwb.file.yaml Outdated Show resolved Hide resolved
oruebel
oruebel commented Jun 12, 2021
View reviewed changes
core/nwb.base.yaml Outdated Show resolved Hide resolved
@rly rly added this to the NWB 2.4.0 milestone Jun 14, 2021
rly
rly reviewed Jul 20, 2021
View reviewed changes
core/nwb.icephys.yaml Outdated Show resolved Hide resolved
@rly
Copy link
Contributor

rly commented Jul 20, 2021

@oruebel Looks like tests in the accompanying NeurodataWithoutBorders/pynwb#1349 pass so this is good to merge into dev.

@oruebel oruebel merged commit 55f264d into dev Jul 20, 2021
@oruebel oruebel deleted the add/icephys_meta_schema branch July 20, 2021 21:42
@oruebel oruebel mentioned this pull request Aug 5, 2021
Merged
3 tasks
@oruebel oruebel mentioned this pull request Aug 12, 2021
Merged
3 tasks
@stephprince stephprince mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rly rly rly approved these changes

@ajtritt ajtritt Awaiting requested review from ajtritt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
NWB 2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oruebel @rly