Added optionality for x,y,z, filtering and impedance #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, @h-mayorquin! Can you implement the corresponding changes in pynwb? |
6 tasks
…tion_for_extracellular_electrode_table
rly
approved these changes
May 26, 2022
rly
deleted the
update_required_condition_for_extracellular_electrode_table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is the first draft of the changes that should fix #505. This is my first PR here so I will welcome any help with it. I am not sure if anything else should be modified. A brief exploration in the repository gave me the idea that everything is propagated automatically from there.
Also, maybe we could modify the doc for
referenceas it seems quite unspecific as we have discussed before:nwb-schema/core/nwb.file.yaml
Lines 325 to 329 in c90e272
Previous discussion:
https://nwb-users.slack.com/archives/C5XKC14L9/p1646424876546959
EDIT:
It seems that the
referenceissue is already covered in #498.PR checklist for schema changes
docs/format/source/format_release_notes.rst