-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OnePhotonSeries #523
Add OnePhotonSeries #523
Conversation
Splitting this PR, which introduces the basic In the end, I think adding enhanced support for custom Devices like this is a separate topic from adding support for It's also my opinion that going down the road of thoroughly documenting every possible custom device configuration parameter is so open-ended and dynamic that we should either only support free-form text (which is already supported by the |
@oruebel @rly @bendichter Met with @DaveOC90 today who confirmed this new object captures and describes all the necessary components of their experiments. PR is now ready for review. |
Overall the schema looks good to me. I just had a couple of minor questions/comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We should ideally also get approval from @bendichter and @rly
@oruebel @bendichter Are we good to merge this? |
Field of view removed |
Looks good. Please add and test a PyNWB API for this before we merge. This looks like a relatively simple data type. I wonder whether the |
@CodyCBakerPhD I believe this would be a minor change, since it does not break backwards compatibility. Could you please update the changelog accordingly? |
@bendichter Done, also included the subject attribute addition with it since they are 'new features added in a back-compatible manner' |
Where is this included here? |
In the changelog sectioning: https://github.com/NeurodataWithoutBorders/nwb-schema/pull/523/files#diff-9223a9a6538334955ca2145d2b76549cdebe59e8842243d6fd74518c43ae9016L6-R14 |
WIP following the discussion of #283
Summary of changes
Checklist
For all schema changes:
docs/format/source/format_release_notes.rst
.If this is the first schema change after a schema release (i.e., the version string in
core/nwb.namespace.yaml
does notend in "-alpha"), then:
core/nwb.namespace.yaml
andcore/nwb.file.yaml
to the next major/minor/patchversion with the suffix "-alpha". For example, if the current version is 2.4.0 and this is a minor change, then the
new version string should be "2.5.0-alpha".
version
variable indocs/format/source/conf.py
to the next version without thesuffix "-alpha", e.g., "2.5.0".
release
variable indocs/format/source/conf.py
to the next version with the suffix"-alpha", e.g., "2.5.0-alpha".
docs/format/source/format_release_notes.rst
for the new versionwith the date "Upcoming" in parentheses.
Resolves #283