-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Check]: Add experimenter form check using DANDI regex #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendichter
reviewed
Jul 12, 2022
bendichter
reviewed
Jul 12, 2022
Co-authored-by: Ben Dichter <[email protected]>
bendichter
approved these changes
Jul 12, 2022
Codecov Report
@@ Coverage Diff @@
## dev #227 +/- ##
==========================================
+ Coverage 94.45% 94.83% +0.38%
==========================================
Files 16 17 +1
Lines 865 890 +25
==========================================
+ Hits 817 844 +27
+ Misses 48 46 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #33
Checks the text form of each experimenter against the DANDI regex pattern (imported directly from there in case they ever update it).
Check has early return in the event that DANDI is not installed (with informative warning message).
Also incorporates that byte-string fix we needed for publications, which has a similar kind of structure to this.