Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Check]: Add experimenter form check using DANDI regex #227

Merged
merged 8 commits into from
Jul 12, 2022

Conversation

CodyCBakerPhD
Copy link
Collaborator

fix #33

Checks the text form of each experimenter against the DANDI regex pattern (imported directly from there in case they ever update it).

Check has early return in the event that DANDI is not installed (with informative warning message).

Also incorporates that byte-string fix we needed for publications, which has a similar kind of structure to this.

@CodyCBakerPhD CodyCBakerPhD added the category: new check a new best practices check to apply to all NWBFiles and their contents label Jul 11, 2022
@CodyCBakerPhD CodyCBakerPhD self-assigned this Jul 11, 2022
@CodyCBakerPhD
Copy link
Collaborator Author

CodyCBakerPhD commented Jul 11, 2022

Oh yeah, SS of how the warning appears (in a small window anyway):

image

EDIT: Not applicable any more

@bendichter bendichter self-requested a review July 12, 2022 16:08
@codecov-commenter
Copy link

Codecov Report

Merging #227 (b15600c) into dev (1d35700) will increase coverage by 0.38%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #227      +/-   ##
==========================================
+ Coverage   94.45%   94.83%   +0.38%     
==========================================
  Files          16       17       +1     
  Lines         865      890      +25     
==========================================
+ Hits          817      844      +27     
+ Misses         48       46       -2     
Flag Coverage Δ
unittests 94.83% <88.46%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwbinspector/checks/images.py 86.66% <86.66%> (ø)
nwbinspector/checks/nwbfile_metadata.py 98.80% <90.90%> (-1.20%) ⬇️
nwbinspector/nwbinspector.py 93.50% <0.00%> (+1.00%) ⬆️
nwbinspector/utils.py 89.04% <0.00%> (+4.10%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: new check a new best practices check to apply to all NWBFiles and their contents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add Check]: Check that if experimenters string does not have comma
3 participants